Feature: OR-ed plugins #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reporting checking errors to the user, the fail_on_faults routine was using the carp/croak methods, which always shows the filename and line number where the error occurs, even when the error message ends in a newline. We don't need this information because it always shows the same place in which the routine is invoked. Thanks @nugged for bringing this to my attention. [0] Ref0: gnustavo@6795420#r113136608
This was referenced Sep 19, 2023
Contributor
Author
|
I've added another commit which makes things a bit less ugly and allows us to log what was evaluated and how. |
Contributor
Author
|
Even though functionally the same, I think doing it this way is a bit nicer. @gnustavo Could you please share your thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Fixes #58 (CheckLog could be OR-ed with CheckJira)
Plugins separated by a pipe, will be OR-ed. This is in addition to, and can be combined with, the existing behaviour where any individually define plugins all need to match.
All defined plugins will be executed, and in the end we evaluate if any such "conditions" have failed.