Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testHopeful for the NSURLSession related tests #478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add testHopeful for the NSURLSession related tests #478

wants to merge 1 commit into from

Conversation

gcasa
Copy link
Member

@gcasa gcasa commented Dec 15, 2024

Make these tests hopeful so they don't fail on MSVC.

@gcasa gcasa requested a review from rfm as a code owner December 15, 2024 05:44
@triplef triplef requested a review from hmelder December 16, 2024 07:40
@rfm
Copy link
Contributor

rfm commented Dec 18, 2024

Hugo told me he's looking into this failure, and as far as I know it's not due to some intractable system dependent issue:
If we can have it fixes in a reasonable timeframe I'd rather do that than marking it as hopeful ... that's really for things where we don't expect the test to pass any time soon.
Still, if we can't fix it fairly promptly then this does make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfm rfm Awaiting requested review from rfm rfm is a code owner

@hmelder hmelder Awaiting requested review from hmelder

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcasa @rfm