Fix computation for _overrideCLASSMethod_foo in GSTheme.m #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start of string is (name+9)
- 'ptr' is the end of the desired substring, so the length
should be (ptr - (name + 9)) which is (ptr - name) - 9)
fredkiefer
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there was an implementation prior to 2010 that used this arithmetic.
Uncovered when I began a holiday project to update Rik.theme to compile with clang.
Test this modification with the updated theme here
https://github.com/mclarenlabs/rik.theme
The theme still has many NSLog statements in it logging the overrides. I will remove them
when this change is confirmed and the theme tested by someone else. I've only tested with
clang on Debian12 so far, but it seems to be fine on a number of applications. The animated
"Default" button is even working.