use 10.7 needsLayout property #1
Conversation
|
@fredkiefer this seems to mostly work. What do you think? Due to this change? I don't know, things didn't compile for years... |
|
I made a separate change where I renamed the local ivar instead to avoid clash and that one works better (see: https://github.com/gnustep/libs-simplewebkit/tree/avoid_ivarclash). The main difference between the two branches is that by using GS needsLayout, a relayout is triggered by just a mouse-over on the View. Do you think that is correct, @fredkiefer ? seems overkill |
Sources/WebHTMLDocumentView.m
Outdated
| @@ -733,7 +733,7 @@ - (void) layout; | |||
| #if 0 | |||
| NSLog(@"%@ %@", NSStringFromClass([self class]), NSStringFromSelector(_cmd)); | |||
| #endif | |||
| _needsLayout=NO; | |||
| [super setNeedsLayout: NO]; | |||
There was a problem hiding this comment.
@fredkiefer checking the super implementation here:
https://github.com/gnustep/libs-gui/blob/f63f89dd050d6bf47c9fbd0fa36b4e81fbbb615b/Source/NSView.m#L5195
means this will not work, since it will skip NO.
try to get rid of local IVAR which now duplicates NSView