proc,dwarf: support string constant parse#4022
Draft
Zxilly wants to merge 1 commit intogo-delve:masterfrom
Draft
proc,dwarf: support string constant parse#4022Zxilly wants to merge 1 commit intogo-delve:masterfrom
Zxilly wants to merge 1 commit intogo-delve:masterfrom
Conversation
aarzilli
reviewed
Jun 12, 2025
Member
aarzilli
left a comment
aarzilli
left a comment
There was a problem hiding this comment.
Please disregards my comments here until the linker change is merged, I don't want you to do work that has to be changed later.
| ctyp.initialized = true | ||
| slices.SortFunc(ctyp.values, func(a, b constantValue) int { | ||
| return cmp.Compare(a.value, b.value) | ||
| return cmp.Compare(a.value.ExactString(), b.value.ExactString()) |
Member
There was a problem hiding this comment.
Numbers shouldn't be sorted as string (nor should we do a conversion to string to sort numbers). I think that storing everything as a constant.Value is probably a mistake, strings and ints should stay in different fields.
| @@ -2321,7 +2323,7 @@ func (cm constantsMap) Get(typ godwarf.Type) *constantType { | |||
|
|
|||
| func (ctyp *constantType) describe(n int64) string { | |||
Member
There was a problem hiding this comment.
This function should be changed to also handle string constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch provides corresponding parsing support for CL https://go.dev/cl/677915, which is currently under review.