terminal/starlark: fix string output with write_file()#4223
Open
89oso wants to merge 1 commit intogo-delve:masterfrom
Open
terminal/starlark: fix string output with write_file()#422389oso wants to merge 1 commit intogo-delve:masterfrom
write_file()#422389oso wants to merge 1 commit intogo-delve:masterfrom
Conversation
This change fixes the string output when using `write_file()`. Fixes go-delve#4222
aarzilli
reviewed
Dec 23, 2025
| case starlark.Bytes: | ||
| data = []byte(v) | ||
| default: | ||
| err := fmt.Errorf("second argument of write_file must be a string or bytes, got %s", args[1].Type()) |
Member
There was a problem hiding this comment.
I think the default should still be to call String.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4222
example.star:test1: