Close projection iterators before handling or checkpointing - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processor currently handles events and saves checkpoints while its
ReadAlliterator remains open. A reader and checkpoint store backed by the same bounded connection pool can therefore deadlock while each processor holds one connection and waits for another.This change reads events into bounded batches, closes each iterator successfully, and only then invokes handlers and checkpoint saves. The default batch size is 500, and non-positive explicit batch sizes are rejected so an unbounded history is never buffered in memory. Close failures are fatal and suppress every callback from that batch; accepted prefixes still run before later read failures, with handler and checkpoint failures retaining their existing precedence.
Cancellation is checked throughout collection, after close, between buffered events, and around the durable head checkpoint. A full batch triggers another immediate read and only a short read can establish the store head. Iterator and fold documentation now makes resource ownership explicit.
Verification:
go test -count=1 -race ./...go vet ./...go build ./...golangci-lint runCloses #54