[UI] change review status icons on pr view style to github style

[a1012112796]

I think the github style is more meaningfull, so make this chang

• change the icon of ApproveReview pr from "eye" to "check" like github
• change the icon of RejectReview pr from "x" to "request-change" like github

view:

[silverwind]

Got some before/after screenshots?

[lunny]

Screenshots are welcome.

[a1012112796]

Sorry , I forgot it.
This change have two main part

• first , change icon of approve from eye to check and change the icon for Reject from x to request-change. because I think the github style is more meaningfull.
  the compare view is bellow
  now used:
  
  changed to:
  

after this change , I found that these icons include "eye" , "check" , "lock" and "key" can't bound at the timeline like the "primitive-dot", but the github can, but I don't know how to do it, so just add a additional "primitive-dot" to make these item onto the time-line

Remove it , because It's not a perfect solution.

[codecov-io]

Codecov Report

Merging #10737 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #10737      +/-   ##
==========================================
- Coverage   43.50%   43.46%   -0.04%     
==========================================
  Files         597      597              
  Lines       83916    83916              
==========================================
- Hits        36504    36472      -32     
- Misses      42903    42932      +29     
- Partials     4509     4512       +3     

Impacted Files	Coverage Δ
models/review.go	42.75% <100.00%> (ø)
modules/indexer/stats/queue.go	62.50% <0.00%> (-18.75%)	⬇️
modules/indexer/stats/db.go	40.62% <0.00%> (-9.38%)	⬇️
modules/git/repo_language_stats.go	66.17% <0.00%> (-4.42%)	⬇️
services/pull/check.go	50.00% <0.00%> (-3.66%)	⬇️
modules/git/command.go	86.95% <0.00%> (-2.61%)	⬇️
services/pull/patch.go	61.93% <0.00%> (-2.59%)	⬇️
services/pull/temp_repo.go	29.05% <0.00%> (-2.57%)	⬇️
models/unit.go	41.97% <0.00%> (-2.47%)	⬇️
modules/queue/workerpool.go	56.93% <0.00%> (-1.07%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3723b06...6b146f5. Read the comment docs.

[a1012112796]

Hello, Are these changes usefull?Looking forward to replys , Thanks .

[silverwind]

New icons seem reasonable. I wonder if there is a better solution for this though:

Is the example just a neutral review or a negative one? If neutral, the icon should be grey ideally. If you can't get the icon into the time line, maybe just indicate intent of the review in the colored dot (red,green,grey) and remove the icon.

[lunny]

I like the new icons. Thanks! @a1012112796

[a1012112796]

now, I just change the icons style . for the problem about some items can't bound on the time-line, left it and wait other contributors who can solve it

[a1012112796]

Hello, How about these changes now? Looking forward to replys , Thanks .

[silverwind]

for the problem about some items can't bound on the time-line

I can't seem to figure it out either. Can't see any style that would cause it, it's weird.

[guillep2k]

@a1012112796 could you please update the screenshots?

[a1012112796]

@guillep2k hello, these screenshots are same as now, all not right screenshots which are add by me has been deleted.
#10737 (comment)
#10737 (comment)

[a1012112796]

I wander the status of this PR now ...