Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstraction layer to check if the repository exists on disk #33874

Merged
merged 6 commits into from
Mar 14, 2025
Merged

Add abstraction layer to check if the repository exists on disk #33874

merged 6 commits into from
Mar 14, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 13, 2025 •
edited
Loading

Extract from #28966

This PR uses gitrepo.IsRepositoryExist instead of util.IsExist to detect whether the repository exist in disk. This will move RepoPath detail behind of package gitrepo to make it easier to do possible changes where storing the repositories.

No code change

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 13, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 13, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 13, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 13, 2025
@delvh delvh changed the title Use gitrepo.IsRepositoryExist instead of util.IsExist to detect whether the repository exist in disk Add abstraction layer to check if the repository exists on disk Mar 13, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2025
@lunny lunny enabled auto-merge (squash) March 14, 2025 02:43
@lunny lunny merged commit 9c673d0 into go-gitea:main Mar 14, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 14, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2025
@lunny lunny deleted the lunny/repo_exist branch March 14, 2025 04:28
@lunny lunny mentioned this pull request Mar 14, 2025
Merged
techknowlogick pushed a commit that referenced this pull request Mar 14, 2025
@lunny
Add abstraction layer to delete repository from disk (#33879)
55cc649 
Extract from #28966 
Follow #33874
This was referenced Mar 14, 2025
Merged
Merged
Merged
techknowlogick pushed a commit that referenced this pull request Mar 16, 2025
@lunny
Move hooks function to gitrepo and reduce expose repopath (#33890)
7fd44a8 
Extract from #28966 
Follow #33874
@lunny lunny mentioned this pull request Mar 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@Zettat123 Zettat123 Zettat123 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @wxiaoguang @Zettat123 @delvh @GiteaBot