Mark parent directory as viewed when all files are viewed

[kerwin612]

Fix #25644

before:

after:

[lunny]

last call @go-gitea/technical-oversight-committee @wxiaoguang @delvh

[delvh]

LGTM from my side.
While I don't quite like the approach we chose, that can still be fixed afterward.
Let's get this merged first

[wxiaoguang]

While I don't quite like the approach we chose, that can still be fixed afterward.

Agree, the current approach looks too hacky and fragile

But I do not see whether there would really be a fix "afterward".

Maybe it's easier and clearer to get a clear and complete fix in this PR

[delvh]

@wxiaoguang the way I see it is the following:
The intended functionality is valuable and should be conceptually included in Gitea.
The current implementation should work without significant problems, even though it may not be optimal.
As the last call has been invoked, the TOC is now required to decide whether the PR (-> the whole feature in most cases) makes it into Gitea.
If this PR is closed, the chance of the feature being merged in the future is small, historically speaking.
The only exception I can think of was the recent file-icons PR.
I have seen very few other exceptions that received a follow-up improvement PR.

My approach to such decisions is that when a feature is conceptually valuable and doesn't introduce backwards-compatibility issues, it should be merged.
I agree, it will slightly increase the tech debt of Gitea.
But the usefulness of this feature outweighs the added tech debt.
Since there's no backwards compatibility concerns here, I'm in favor of merging it now.
If there's never going to be a cleanup, then so be it.
If there is, even better.

[wxiaoguang]

I won't block it, but IMO the benefit is smaller than the technical debt it brings. It only marks the viewed file/folder gray, but it breaks the whole diff file tree Vue reactivity system.

Anyway, I have spent too much time on the various frontend bugs and refactorings. I am tired and won't say more.

[wxiaoguang]

I did some refactoring: as discussed above, let backend prepare data as much as possible, to avoid abusing Vue reactivity system

There are still some TODOs (need to write some tests) (done)

And I found a strange problem (not sure whether it is a regression or a legacy problem): The IsViewed field is always false due to the filesViewedState map is always nil. I have left // FIXME: filesViewedState is always nil? in code, @delvh do you have ideas?

[delvh]

@wxiaoguang the field will be nil as long as you haven't viewed or unviewed a single file in the PR.
It is only created once the first I have viewed a file event happens.

[wxiaoguang]

@wxiaoguang the field will be nil as long as you haven't viewed or unviewed a single file in the PR. It is only created once the first I have viewed a file event happens.

I have clicked "Viewed" and marked a file as viewed, that map is still empty.

[wxiaoguang]

For example, I have refreshed the page:

[delvh]

Now that's interesting.
I don't remember implementing it that way.
Why is the button still being shown correctly in this case?
The way I implemented it, the button shouldn't be shown as viewed either in that case…

[wxiaoguang]

Now that's interesting. I don't remember implementing it that way. Why is the button still being shown correctly in this case? The way I implemented it, the button shouldn't be shown as viewed either in that case…

That's why we need to "maintain" a project, otherwise strange things happens. I can see there are a lot of changes to the "DiffFileTree", maybe some changes are not quite right.

[wxiaoguang]

@delvh do you have ideas about how to make it right?

[delvh]

What exactly?
This specific PR?
Or how we can establish guidelines to increase the maintainability of the entire project?

[wxiaoguang]

And I found a strange problem (not sure whether it is a regression or a legacy problem): The IsViewed field is always false due to the filesViewedState map is always nil. I have left // FIXME: filesViewedState is always nil? in code

I mean fix this problem.

[wxiaoguang]

And I found a strange problem (not sure whether it is a regression or a legacy problem): The IsViewed field is always false due to the filesViewedState map is always nil. I have left // FIXME: filesViewedState is always nil? in code

I mean fix this problem.

The proper fix should be like this: 291012d

[wxiaoguang]

And I found a strange problem (not sure whether it is a regression or a legacy problem): The IsViewed field is always false due to the filesViewedState map is always nil. I have left // FIXME: filesViewedState is always nil? in code, @delvh do you have ideas?

@delvh I fixed the problem by my understanding. If anything is wrong, feel free to point out or propose following up changes.