-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Some refactors about GetMergeBase #36186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CI failure is also related. Do rerun the CI multiple times before merge to ensure there is no regression. |
…nny/some_refactors
…nny/some_refactors
CI failure is still related |
Added a lock for the fetch operations to the repository and rerun the CI many times and all PASS. |
Maybe fix #32018
gitrepo.GetMergeBasemethod instead of other two implementations.FetchRemoteCommitso that we don't need to add manyremoteto the git repository to avoid possible git lock conflicts. A lock will start when invoke the function, it will be invoked when cross-repository comparing. The head repository will fetch the base repository's base commit id. In most situations, it should lock the fork repositories so that it should not become a bottleneck.GetCompareInfoto remove unnecessarily adding remote.SignMerge.