jsontext: Preserve the internal buffer between Reset calls #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jsontext decoder throws away the internal buffer on each Reset call. This makes decoding one message at a time pretty wasteful since each new message will cause at least one allocation for the buffer. This commit makes sure the buffer gets reused when the decoder is reset with a new reader. If unbounded growth for the slice is a concern, I can add an option limiting the maxiumum size after which the bytes buffer will be thrown away and a new one can be allocated.
|
Hi, thanks for the PR, but this repository is now frozen as future development has moved to the Go standard library. That said, I don't think this is quite the right fix as this could unintentionally alias the internal buffer of a |
|
I could make the proper fix upstream for you, or did you want to take a shot at it? |
|
Thanks for the pointer, let me raise an upstream PR 👍 |
|
Upstream PR here golang/go#74120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jsontext decoder throws away the internal buffer on each Reset call. This makes decoding one message at a time pretty wasteful since each new message will cause at least one allocation for the buffer.
This commit makes sure the buffer gets reused when the decoder is reset with a new reader. If unbounded growth for the slice is a concern, I can add an option limiting the maxiumum size after which the bytes buffer will be thrown away and a new one can be allocated.