-
Notifications
You must be signed in to change notification settings - Fork 10
feat(test reports): test_report key functionality #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (50.61%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 52.95% 50.61% -2.35%
==========================================
Files 124 127 +3
Lines 5342 5613 +271
==========================================
+ Hits 2829 2841 +12
- Misses 2300 2548 +248
- Partials 213 224 +11
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This branch wires the worker into the new test reports + object storage pipeline by:
test_reportkey.Architecture
1. Worker config + storage hookup
cmd/vela-worker/flags.go,run.go,worker.gostorage.Setup.Workergains fields forStorage *storage.Setup(config) andStorage storage.Storage(runtime client).cmd/vela-worker/operate.goVelaClient.Storage.GetInfo()to fetch storage configuration from the server.storage.New(...).w.Storageand logs driver/bucket/endpoint.w.Storage = nil.2. Executor setup (linux/local)
executor.Setupnow includes aStorage storage.Storagefield.cmd/vela-worker/exec.gow.Storagewas successfully initialized, it is passed into the executor setup.executor.Setupstruct instead of an inline literal.executor/executor_test.goStoragefield inexecutor.Setup.3. Linux / local executor behavior for test reports
executor/linux/{build.go,stage.go,outputs.go,report.go,testattachments.go}executor/local/{build.go,stage.go}and related testsThese pieces:
test_reportkey, they:4. Runtime integration
runtime/docker/test_report.go(+test_report_test.go)runtime/engine.goruntime/kubernetes/container.goPollFileNamesas a no‑op for Kubernetes: test result file polling is not supported for dynamic pod environments yet.5. Step skipping, middleware, and wiring
internal/step/skip.go(+ tests)router/middleware/executor/executor_test.goStoragefield inexecutor.Setup.6. Dependencies
go.mod,go.sumsdk-go, server storage packages, and Docker) to versions that include the new test‑report and storage APIs.