Skip to content

feat!: add container resource limits and build isolation tracking #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delta592 wants to merge 18 commits into from

fix: add more tests and fix some

a1999de
Select commit
Loading
Failed to load commit list.
Closed

feat!: add container resource limits and build isolation tracking #654

fix: add more tests and fix some
a1999de
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 9, 2025 in 1s

70.13% (target 90.00%)

View this Pull Request on Codecov

70.13% (target 90.00%)

Details

Codecov Report

❌ Patch coverage is 90.60052% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.13%. Comparing base (14f88b0) to head (a1999de).

Files with missing lines Patch % Lines
cmd/vela-worker/exec.go 85.45% 6 Missing and 2 partials ⚠️
cmd/vela-worker/operate.go 0.00% 7 Missing ⚠️
cmd/vela-worker/run.go 0.00% 7 Missing ⚠️
cmd/vela-worker/start.go 0.00% 6 Missing ⚠️
executor/linux/secret.go 20.00% 4 Missing ⚠️
runtime/docker/container.go 86.36% 1 Missing and 2 partials ⚠️
runtime/kubernetes/container.go 83.33% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (70.13%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #654       +/-   ##
===========================================
+ Coverage   58.24%   70.13%   +11.88%     
===========================================
  Files         123      123               
  Lines        8368     8517      +149     
===========================================
+ Hits         4874     5973     +1099     
+ Misses       3283     2301      -982     
- Partials      211      243       +32
Files with missing lines Coverage Δ
cmd/vela-worker/flags.go 100.00% <ø> (+100.00%) ⬆️
executor/linux/build.go 73.60% <100.00%> (-1.91%) ⬇️
executor/linux/service.go 79.15% <100.00%> (ø)
executor/linux/step.go 78.39% <100.00%> (ø)
executor/local/build.go 73.19% <100.00%> (-2.49%) ⬇️
executor/local/service.go 93.75% <100.00%> (ø)
executor/local/step.go 89.83% <100.00%> (ø)
mock/docker/config.go 100.00% <100.00%> (+100.00%) ⬆️
mock/docker/container.go 96.23% <100.00%> (+96.23%) ⬆️
mock/docker/distribution.go 100.00% <100.00%> (+100.00%) ⬆️
... and 31 more

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov