Skip to content

Conversation

@ecrupper
Copy link
Contributor

Docker v29.0.1 has a lot of breaking changes and the Moby project is only publishing two public modules (moby/moby/client and moby/moby/api). This PR migrates the Docker runtime to use these modules. There should be no functional changes to the worker code, but it will require an upgrade for Docker on the host running the worker.

The moby project is no longer opening the capabilities set as a public resource for code, so I removed the capabilities verification in the setup of the runtime.

@ecrupper ecrupper requested a review from a team as a code owner November 18, 2025 17:25
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 10.02786% with 323 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.80%. Comparing base (ca78232) to head (c2b8be8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mock/docker/container.go 0.00% 84 Missing ⚠️
mock/docker/image.go 0.00% 50 Missing ⚠️
mock/docker/volume.go 0.00% 35 Missing ⚠️
mock/docker/network.go 0.00% 34 Missing ⚠️
mock/docker/plugin.go 0.00% 19 Missing ⚠️
mock/docker/swarm.go 0.00% 14 Missing ⚠️
mock/docker/swarm_service.go 0.00% 11 Missing ⚠️
mock/docker/config.go 0.00% 10 Missing ⚠️
mock/docker/exec.go 0.00% 10 Missing ⚠️
mock/docker/swarm_secret.go 0.00% 10 Missing ⚠️
... and 8 more

❌ Your project check has failed because the head coverage (53.80%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   52.95%   53.80%   +0.84%     
==========================================
  Files         124      128       +4     
  Lines        5342     5243      -99     
==========================================
- Hits         2829     2821       -8     
+ Misses       2300     2207      -93     
- Partials      213      215       +2     
Files with missing lines Coverage Δ
runtime/docker/container.go 80.60% <100.00%> (+3.10%) ⬆️
runtime/docker/docker.go 73.91% <100.00%> (-1.09%) ⬇️
runtime/docker/image.go 64.70% <100.00%> (-1.01%) ⬇️
runtime/docker/network.go 93.93% <100.00%> (-0.18%) ⬇️
runtime/docker/volume.go 84.12% <100.00%> (+0.52%) ⬆️
runtime/setup.go 100.00% <ø> (ø)
mock/docker/distribution.go 0.00% <0.00%> (ø)
mock/docker/registry.go 0.00% <0.00%> (ø)
mock/docker/checkpoint.go 0.00% <0.00%> (ø)
mock/docker/image_build.go 0.00% <0.00%> (ø)
... and 14 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants