Skip to content

Fix and improve the sendOtp for loop #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix and improve the sendOtp for loop #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c82f3
Fix what length is used in the sendOtp for loop.
Berna-L Apr 8, 2023
af5fef7
Better handling of multi-IP OTP send.
Berna-L Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions lib/communication.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,24 +27,25 @@ class Communication {
if (ips == null)
return false;

List<String>? ipList = ips.split(';');

for (var currentIp = 0; currentIp < ips.length; currentIp++) {
var ip = ipList[currentIp];
var uri = Uri.http("$ip:4646", "ffxivlauncher/$otp");
try {
await http.get(uri);
} on http
.ClientException catch (e) { // This happens since the XL http server is badly implemented, no problem though
developer.log('ClientException: ' + uri.toString(),
name: 'com.goatsoft.xl_otpsend', error: e);
return true;
}
catch (e) {
developer.log('could not send to: ' + uri.toString(),
name: 'com.goatsoft.xl_otpsend', error: e);
}
List<String> ipList = ips.split(";");
return await Future.any(ipList.map((e) => sendOtpToIp(otp, e)));
}

static Future<bool> sendOtpToIp(String otp, String ip) async {
var uri = Uri.http("$ip:4646", "ffxivlauncher/$otp");
try {
await http.get(uri).timeout(const Duration(seconds: 5));
return true;
} on http
.ClientException catch (e) { // This happens since the XL http server is badly implemented, no problem though
developer.log('ClientException: ' + uri.toString(),
name: 'com.goatsoft.xl_otpsend', error: e);
return true;
}
catch (e) {
developer.log('could not send to: ' + uri.toString(),
name: 'com.goatsoft.xl_otpsend', error: e);
}
return true;
return false;
}
}