Skip to content

Conversation

michael-schwarz
Copy link
Member

Closes #1664.

@sim642 sim642 changed the title Ability to enable/disable may_race checks per race diges Ability to enable/disable may_race checks per race digest Feb 12, 2025
@sim642
Copy link
Member

sim642 commented Jul 10, 2025

This was useful for experiments, but those are now done I guess.

I'm wondering how much sense it makes to keep this extra configurability for the future. What this allows is having some analysis active but not using the information it computes to exclude races — a feature that no user would ever want.
It also creates a huge opportunity for misunderstanding and misconfiguration: the options are enabled by default, which makes it seem like all of the features are being used when in fact they are not. Only some of us would know that they do nothing unless some corresponding analysis is also activated. Having the defaults flipped wouldn't be any better: one might then try to enable them without effect or try to activate some analysis without effect.

The race digest experiments are tagged anyway and these changes could easily be cherry-picked for future experiments if really necessary.

@michael-schwarz
Copy link
Member Author

Closing as this is included in #1666 which we'll keep open until we have cut the artifact release from it. A separate PR is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to enable/disable may_race checks per race digest
2 participants