Add minor changes (#258)

bench.sh

@@ -5,10 +5,10 @@ set +e
 clear
 
 echo "postgres"
-SODA_DIALECT=postgres go test -bench=.
+SODA_DIALECT=postgres go test -tags sqlite -bench=.
 echo "--------------------"
 echo "mysql"
-SODA_DIALECT=mysql go test -bench=.
+SODA_DIALECT=mysql go test -tags sqlite -bench=.
 echo "--------------------"
 echo "sqlite"
-SODA_DIALECT=sqlite go test -bench=.
+SODA_DIALECT=sqlite go test -tags sqlite -bench=.

executors.go

@@ -110,9 +110,10 @@ func (c *Connection) Create(model interface{}, excludeColumns ...string) error {
 				return err
 			}
 
-			cols := columns.ForStructWithAlias(m.Value, m.TableName(), m.As)
+			tn := m.TableName()
+			cols := columns.ForStructWithAlias(m.Value, tn, m.As)
 
-			if sm.TableName() == m.TableName() {
+			if tn == sm.TableName() {
 				cols.Remove(excludeColumns...)
 			}
 
@@ -161,10 +162,11 @@ func (c *Connection) Update(model interface{}, excludeColumns ...string) error {
 				return err
 			}
 
-			cols := columns.ForStructWithAlias(model, m.TableName(), m.As)
+			tn := m.TableName()
+			cols := columns.ForStructWithAlias(model, tn, m.As)
 			cols.Remove("id", "created_at")
 
-			if m.TableName() == sm.TableName() {
+			if tn == sm.TableName() {
 				cols.Remove(excludeColumns...)
 			}
 

finders.go

@@ -37,7 +37,7 @@ func (q *Query) Find(model interface{}, id interface{}) error {
 			break
 		}
 	}
-	idq := fmt.Sprintf("%s.id = ?", tn)
+	idq := m.whereID()
 	switch t := id.(type) {
 	case uuid.UUID:
 		return q.Where(idq, t.String()).First(model)
@@ -220,7 +220,7 @@ func (q *Query) eagerAssociations(model interface{}) error {
 		return err
 	}
 
-	//disable eager mode for current connection.
+	// disable eager mode for current connection.
 	q.eager = false
 	q.Connection.eager = false
 

sql_builder.go

@@ -209,8 +209,9 @@ func (sq *sqlBuilder) buildPaginationClauses(sql string) string {
 	return sql
 }
 
+// columnCache is used to prevent columns rebuilding.
 var columnCache = map[string]columns.Columns{}
-var columnCacheMutex = sync.Mutex{}
+var columnCacheMutex = sync.RWMutex{}
 
 func (sq *sqlBuilder) buildColumns() columns.Columns {
 	tableName := sq.Model.TableName()
@@ -219,11 +220,11 @@ func (sq *sqlBuilder) buildColumns() columns.Columns {
 		asName = strings.Replace(tableName, ".", "_", -1)
 	}
 	acl := len(sq.AddColumns)
-	if acl <= 0 {
-		columnCacheMutex.Lock()
+	if acl == 0 {
+		columnCacheMutex.RLock()
 		cols, ok := columnCache[tableName]
-		columnCacheMutex.Unlock()
-		//if alias is different, remake columns
+		columnCacheMutex.RUnlock()
+		// if alias is the same, don't remake columns
 		if ok && cols.TableAlias == asName {
 			return cols
 		}