-
Notifications
You must be signed in to change notification settings - Fork 7
[WIP] New endpoints, webhooks, making certain links embeddable (ie. post, student) #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[WIP] New endpoints, webhooks, making certain links embeddable (ie. post, student) #346
Conversation
…ify additional fields as being available within the "embed" context, and decide if we want to auto embed for all endpoints. Since we only specified embeddable
@@ -231,7 +226,12 @@ protected function get_payload( $args ) { | |||
$endpoint = sprintf( '/llms/v1/%1$ss/%2$d', $resource, $args[0] ); | |||
} | |||
|
|||
$payload = llms_rest_get_api_endpoint_data( $endpoint ); | |||
$payload = llms_rest_get_api_endpoint_data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if this change is needed.
@@ -64,10 +63,9 @@ function llms_rest_get_api_endpoint_data( $endpoint, $params = array() ) { | |||
|
|||
$res = rest_do_request( $req ); | |||
$server = rest_get_server(); | |||
$json = wp_json_encode( $server->response_to_data( $res, false ) ); | |||
$json = wp_json_encode( $server->response_to_data( $res, true ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add as a param defaulting to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Dependency Scan (universal) | 0 | 1 | 1 | 0 | ✅ |
Secrets Audit | 0 | 4 | 0 | 0 | ❌ |
Shell Script Analysis | 0 | 0 | 0 | 0 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Secrets Audit | 0 | 4 | 0 | 0 | ❌ |
Shell Script Analysis | 0 | 0 | 0 | 0 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Dependency Scan (universal) | 0 | 0 | 1 | 0 | ✅ |
Secrets Audit | 0 | 4 | 0 | 0 | ❌ |
Shell Script Analysis | 0 | 0 | 0 | 0 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
…ing using object.
Will likely want to specify additional fields as being available within the "embed" context, and decide if we want to auto embed for all endpoints.
New endpoints for:
Description
Fixes #
How has this been tested?
Screenshots
Types of changes
Checklist: