Skip to content

[WIP] New endpoints, webhooks, making certain links embeddable (ie. post, student) #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 30 commits into
base: dev
Choose a base branch
from

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Jun 17, 2025

Will likely want to specify additional fields as being available within the "embed" context, and decide if we want to auto embed for all endpoints.

New endpoints for:

  • Orders
  • Certificates
  • Awarded Certificates
  • Quizzes
  • Quiz Attempts

Description

Fixes #

How has this been tested?

Screenshots

Types of changes

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

…ify additional fields as being available within the "embed" context, and decide if we want to auto embed for all endpoints. Since we only specified embeddable
@ideadude ideadude moved this to Awaiting Review in Development Jun 17, 2025
@@ -231,7 +226,12 @@ protected function get_payload( $args ) {
$endpoint = sprintf( '/llms/v1/%1$ss/%2$d', $resource, $args[0] );
}

$payload = llms_rest_get_api_endpoint_data( $endpoint );
$payload = llms_rest_get_api_endpoint_data(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if this change is needed.

@@ -64,10 +63,9 @@ function llms_rest_get_api_endpoint_data( $endpoint, $params = array() ) {

$res = rest_do_request( $req );
$server = rest_get_server();
$json = wp_json_encode( $server->response_to_data( $res, false ) );
$json = wp_json_encode( $server->response_to_data( $res, true ) );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add as a param defaulting to false?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Dependency Scan (universal) 0 1 1 0
Secrets Audit 0 4 0 0
Shell Script Analysis 0 0 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Secrets Audit 0 4 0 0
Shell Script Analysis 0 0 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Dependency Scan (universal) 0 0 1 0
Secrets Audit 0 4 0 0
Shell Script Analysis 0 0 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

@brianhogg brianhogg changed the title [WIP] Add embeddable to the post and student [WIP] New endpoints, webhooks, making certain links embeddable (ie. post, student) Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting Review
Development

Successfully merging this pull request may close these issues.

1 participant