Select Primitive PDR

[kawikabader]

rendered

[changeset-bot]

⚠️ No Changeset found

Latest commit: dae47d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[akazemier-godaddy]

This document is littered with AI slop, I've highlighted a couple of things as comments, but really the amount of inaccuracies about the current state of bento, and it's inner workings makes it impossible to do a proper review.

This document honestly should be rewritten from scratch, using AI as research is fine, but it does not understand how our code works, the goals that we have and that evident as part of this PDR.

Not only that, but if new primitives are being suggested as part of the pdr, e.g. popover, then I fully expect that to be fleshed out as part of this PDR.

[kawikabader]

This document is littered with AI slop, I've highlighted a couple of things as comments, but really the amount of inaccuracies about the current state of bento, and it's inner workings makes it impossible to do a proper review.

This document honestly should be rewritten from scratch, using AI as research is fine, but it does not understand how our code works, the goals that we have and that evident as part of this PDR.

Not only that, but if new primitives are being suggested as part of the pdr, e.g. popover, then I fully expect that to be fleshed out as part of this PDR.

You are 100% right @akazemier-godaddy . Went through and verified everything against the actual codebase:

• Fixed all import paths (no more @bento/components)
• Removed the render function that didn't match our patterns
• Fixed the Text placeholder issue (now uses a custom SelectValue wrapper)
• Simplified the overlay approach—Select now handles it internally instead of users providing a non-existent Popover component

The PDR should now accurately reflect Bento's actual patterns. Let me know if anything still looks off.

[ddamato-godaddy]

I heard there was a discussion on composition expectations for bento. I was expecting an update to what @jsmith9-godaddy described in his first comment. Where is this doc on that?

[kawikabader]

I heard there was a discussion on composition expectations for bento. I was expecting an update to what @jsmith9-godaddy described in his first comment. Where is this doc on that?

I believe @jsmith9-godaddy is working on a composition doc?

[jsmith9-godaddy]

I believe value is accessible through state, but not through the ListBoxItem props.

[kawikabader]

Am I misunderstanding your question? https://github.com/godaddy/bento/blob/main/packages/listbox/src/listbox-item.tsx#L92