Storybook: Converting to 'exemplar' and adding Knobs story#40
Open
msikora78 wants to merge 4 commits intogodaddy:mainfrom
Open
Storybook: Converting to 'exemplar' and adding Knobs story#40msikora78 wants to merge 4 commits intogodaddy:mainfrom
msikora78 wants to merge 4 commits intogodaddy:mainfrom
Conversation
chrishinrichs
approved these changes
Jan 6, 2020
msluther
approved these changes
Jan 7, 2020
Contributor
msluther
left a comment
msluther
left a comment
There was a problem hiding this comment.
LGTM, one small suggestion on using the storybook preset mechanism to help clean some things up. otherwise 👍
| "test": "npm run unit", | ||
| "prepublish": "npm run test && npm run build", | ||
| "storybook": "start-storybook" | ||
| "storybook": "start-storybook -c ./node_modules/@exemplar/storybook-react" |
Contributor
There was a problem hiding this comment.
You can get around having to do this by creating the file ./.storybook/presets.js and putting this in it:
module.exports = [
'@exemplar/storybook-react'
];Then this can still just be start-storybook
This was
linked to
issues
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix issues #39 and #38. Please let me know if you want me ti change anything...