Repository navigation
Conversation
Faless
force-pushed
the
web/wasm_exceptions
branch
from
October 2, 2026 23:51
8009a1c to
99777f3
Compare
Faless
force-pushed
the
web/wasm_exceptions
branch
from
October 2, 2026 23:52
99777f3 to
0d92eaa
Compare
Collaborator
|
What happens if someone builds with this flag and their extension is loaded in an older version of Godot that doesn't have godotengine/godot#124118? Since we now support building extensions for Godot 4.3+ from a single version of godot-cpp, do we need to add a version check for using this flag? Something like: def parse_version(v):
return tuple(int(x) for x in v.split("."))
def generate(env):
# ...
if not env["disable_exceptions"] and parse_version(env["api_version"]) >= (4, 8):
env.Append(CCFLAGS=["-fwasm-exceptions"])
env.Append(LINKFLAGS=["-fwasm-exceptions"]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on godotengine/godot#124118 which compiles the main runtime with exceptions enabled.