Skip to content

Fix stray pixel artifacts when BaseMaterial3D Deep Parallax is enabled #101551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Calinou wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −5
Open

Fix stray pixel artifacts when BaseMaterial3D Deep Parallax is enabled #101551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions scene/resources/material.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,8 +725,9 @@ void BaseMaterial3D::_update_shader() {
// used. The losers will free their shader.

String texfilter_str;
// Force linear filtering for the heightmap texture, as the heightmap effect
// Force linear filtering with no mipmaps for the heightmap texture, as the heightmap effect
// looks broken with nearest-neighbor filtering (with and without Deep Parallax).
// Mipmaps also result in stray pixel artifacts when Deep Parallax is enabled.
String texfilter_height_str;
switch (texture_filter) {
case TEXTURE_FILTER_NEAREST:
Expand All @@ -739,19 +740,19 @@ void BaseMaterial3D::_update_shader() {
break;
case TEXTURE_FILTER_NEAREST_WITH_MIPMAPS:
texfilter_str = "filter_nearest_mipmap";
texfilter_height_str = "filter_linear_mipmap";
texfilter_height_str = "filter_linear";
break;
case TEXTURE_FILTER_LINEAR_WITH_MIPMAPS:
texfilter_str = "filter_linear_mipmap";
texfilter_height_str = "filter_linear_mipmap";
texfilter_height_str = "filter_linear";
break;
case TEXTURE_FILTER_NEAREST_WITH_MIPMAPS_ANISOTROPIC:
texfilter_str = "filter_nearest_mipmap_anisotropic";
texfilter_height_str = "filter_linear_mipmap_anisotropic";
texfilter_height_str = "filter_linear";
break;
case TEXTURE_FILTER_LINEAR_WITH_MIPMAPS_ANISOTROPIC:
texfilter_str = "filter_linear_mipmap_anisotropic";
texfilter_height_str = "filter_linear_mipmap_anisotropic";
texfilter_height_str = "filter_linear";
break;
case TEXTURE_FILTER_MAX:
break; // Internal value, skip.
Expand Down
Loading