Add use_self_delta_to_fade to NodeOneShot to fade finished animation#101788
Closed
TokageItLab wants to merge 1 commit into
Closed
Add use_self_delta_to_fade to NodeOneShot to fade finished animation#101788TokageItLab wants to merge 1 commit into
use_self_delta_to_fade to NodeOneShot to fade finished animation#101788TokageItLab wants to merge 1 commit into
Conversation
c48dbd3 to
b7566b9
Compare
Member
Author
|
I sent #101792 as an alternative. I think that is a smarter solution as it does not add any extra options. |
Member
Author
|
Superseded by #101792. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, note that this is a band-aid solution.
For example, when there is a 1 second fade in OneShot, when the input TimeScale is 2.0, the fade is actually 0.5 seconds.
This is a fix to address the problem noted in #87009 and to keep the past behavior that has existed since 3.x, but I assume it is not correct in terms of consistency.
For complete consistency, I think the NodeTimeInfo should include the TimeScale and get the remaining time depending on that. However, this is a major rework and should not be done at this stage as it would be a significant behavior change. So, I believe we should rethink this when the update timing to 5.0. (So this and #101792 using prediction.)
For now, enabling this option will allow the fade to work even when the input animation delta is
0.