Skip to content

etcpak: Improve and fix decompression of mipmaps#103573

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
BlueCube3310:etcpak-dec-align-fix
May 19, 2025
Merged

etcpak: Improve and fix decompression of mipmaps#103573
Repiteo merged 1 commit into
godotengine:masterfrom
BlueCube3310:etcpak-dec-align-fix

Conversation

@BlueCube3310
Copy link
Copy Markdown
Contributor

@BlueCube3310 BlueCube3310 commented Mar 4, 2025

Improves the decompression of ETC-compressed textures in a similar way to #103276

Comparison:

master PR
old new

Note: Both images are decompressed since desktop hardware doesn't support ETC compression. More accurate results would require testing this on a mobile device.

Testing project:
non-power-of-two-tex.zip

TODO:

  • Add a testing project

@BlueCube3310 BlueCube3310 force-pushed the etcpak-dec-align-fix branch from fad0c62 to 9820d04 Compare May 9, 2025 08:35
@BlueCube3310 BlueCube3310 marked this pull request as ready for review May 14, 2025 15:40
@BlueCube3310 BlueCube3310 requested a review from a team as a code owner May 14, 2025 15:40
@fire
Copy link
Copy Markdown
Member

fire commented May 14, 2025

Can you help me make a https://imgsli.com/ for easier comparison?

@BlueCube3310
Copy link
Copy Markdown
Contributor Author

Can you help me make a https://imgsli.com/ for easier comparison?

https://imgsli.com/Mzc5Njc0

@BlueCube3310 BlueCube3310 changed the title etcpak: Improve and fix decompression of images with resolutions not divisible by 4 etcpak: Improve and fix decompression of mipmaps May 15, 2025
@BlueCube3310
Copy link
Copy Markdown
Contributor Author

I tested on mobile hardware, can confirm it works as expected.

@akien-mga akien-mga modified the milestones: 4.x, 4.5 May 16, 2025
@Repiteo Repiteo merged commit edce9fd into godotengine:master May 19, 2025
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented May 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants