Skip to content

Fix animation track subproperty hints#104867

Closed
RailKill wants to merge 3 commits into
godotengine:masterfrom
RailKill:fix-animation-subproperty-hint
Closed

Fix animation track subproperty hints#104867
RailKill wants to merge 3 commits into
godotengine:masterfrom
RailKill:fix-animation-subproperty-hint

Conversation

@RailKill
Copy link
Copy Markdown

@RailKill RailKill commented Apr 1, 2025

Simple AnimationPlayer-related fixes:

Bugsquad edit: Fixes #99115 Fixes #102130

@kleonc
Copy link
Copy Markdown
Member

kleonc commented Apr 3, 2025

Seems like this should fix #99115/#102130/#104964.

@kleonc kleonc requested a review from SaracenOne April 3, 2025 11:48
@akien-mga akien-mga requested a review from a team April 3, 2025 12:15
@KoBeWi KoBeWi added regression cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Apr 13, 2025
Copy link
Copy Markdown
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly.

@fire
Copy link
Copy Markdown
Member

fire commented Apr 13, 2025

I would like to ask the animation team to check

@TokageItLab
Copy link
Copy Markdown
Member

Need to squash to follow PR workflow.

@akien-mga
Copy link
Copy Markdown
Member

Need to squash to follow PR workflow.

We can squash before merge if needed, but a @godotengine/animation team review to confirm whether the fix is correct would be good.

Worth noting that #106491 was just opened, taking a different approach.

This PR (#104867) seems maybe less hacky but I'm not very familiar with the issue at hand.

@TokageItLab
Copy link
Copy Markdown
Member

We concluded that the #102130 (comment) approach should be adopted to solve the original problem in animation teams meeting.

obj.get_indexed() should resolve everything,

@akien-mga
Copy link
Copy Markdown
Member

Superseded by #106580. Thanks for the contribution!

@akien-mga akien-mga closed this May 19, 2025
@akien-mga akien-mga added archived and removed cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels May 19, 2025
@akien-mga akien-mga removed this from the 4.5 milestone May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.4 Beta 1 - Animation Sub-Properties Create Wrong Key Type AnimationTrackEditor sub-property handling is not correct

8 participants