Fix animation track subproperty hints#104867
Closed
RailKill wants to merge 3 commits into
Closed
Conversation
Member
Member
|
I would like to ask the animation team to check |
Member
|
Need to squash to follow PR workflow. |
Member
We can squash before merge if needed, but a @godotengine/animation team review to confirm whether the fix is correct would be good. Worth noting that #106491 was just opened, taking a different approach. This PR (#104867) seems maybe less hacky but I'm not very familiar with the issue at hand. |
Member
|
We concluded that the #102130 (comment) approach should be adopted to solve the original problem in animation teams meeting.
|
Member
|
Superseded by #106580. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple AnimationPlayer-related fixes:
Bugsquad edit: Fixes #99115 Fixes #102130