-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
Warn when running low on disk space when performing certain editor operations #105755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
c49f784 to
a71811a
Compare
a71811a to
2244457
Compare
|
I increased it to 100GB everywhere to test the warning. The warning is not yet displayed in the On MacOS, according to "Finder" I have more free space. |
I've added the warning to all advanced import settings dialogs.
This is a GiB (binary prefix) versus GB (decimal prefix) difference. It's why when you buy a 500 GB hard drive, it appears to be 465 GB in the OS 🙂 |
…erations The following editor operations will now warn the user if the available space on the target disk is low: - Saving a scene (< 1 GiB). - Importing a set of resources (< 2 GiB). - Downloading export templates (< 4 GiB). - Installing export templates (< 4 GiB). - Exporting a project (< 10 GiB). - Packing a project as a ZIP file (< 10 GiB).
2244457 to
7e9eb3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested on MacOS and Android.
I think this might be too restrictive. Some people can use Godot on mobile devices (tablets, phones, Steam Deck) where storage is at a premium, and it's totally reasonable to export e.g. a simple 2D game with 200 MB of assets when you're on a 64 GB SD card with only 3-4 GB left. Ideally we should get a feeling for how heavy the PCK is going to be (e.g. by checking the size of I haven't tested the PR to check, but if we can't get a level of accuracy which actually matches the developer's available disk space and project needs, maybe we should just have the possibility to disable these warnings for users who know they're operating within narrow limits. |
I would say there should be different types of warnings. In output (warnings/errors depending on severity), and in extreme cases (0-50MiB free) warn the user with a dialog when they open a project. Especially as this will continue being an issue until the user intervenes to free up space. I'm guessing even a modest Either way it would be nice to get something in for 4.4.2 (or 4.5). At least for the worst-case-scenarios, even if it does not touch the export process (although I would hope that actually running out of data here would just fail/cancel the export). |



The following editor operations will now warn the user if the available space on the target disk is low:
and Invalid PCK on export when running out of disk space #105742.