Skip to content

Evaluator: keep editing after submit#105979

Closed
nubels wants to merge 1 commit into
godotengine:masterfrom
nubels:evaluator-keep-editing-on-text-submit
Closed

Evaluator: keep editing after submit#105979
nubels wants to merge 1 commit into
godotengine:masterfrom
nubels:evaluator-keep-editing-on-text-submit

Conversation

@nubels
Copy link
Copy Markdown
Contributor

@nubels nubels commented May 1, 2025

This is my first pull request, yay! :)

This improves the usability of the evaluator by continuing to edit the expression after submitting, so you don't have to manually activate it each time after submitting.

Before:
CleanShot 2025-05-01 at 10 06 24

After:

CleanShot 2025-05-01 at 10 03 30

@nubels nubels requested a review from a team as a code owner May 1, 2025 08:11
@Chaosus Chaosus added this to the 4.5 milestone May 2, 2025
@AThousandShips AThousandShips modified the milestones: 4.5, 4.x May 2, 2025
@Repiteo Repiteo modified the milestones: 4.5, 4.x Jun 16, 2025
@nubels
Copy link
Copy Markdown
Contributor Author

nubels commented Aug 6, 2025

@Repiteo I'm curious, does this qualify as a new feature or is this a fix that could be included in a beta / rc snapshot?

@arkology
Copy link
Copy Markdown
Contributor

It's definitely a QOL improvement, I really don't understand why it's stuck. And it's just single line of code...
@Repiteo could you please provide more details on why it got stuck?

@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Nov 20, 2025

The feature was implemented by #108391, therefore superseding this PR.
Thanks for the contribution nonetheless.

@KoBeWi KoBeWi closed this Nov 20, 2025
@KoBeWi KoBeWi removed this from the 4.x milestone Nov 20, 2025
@nubels nubels deleted the evaluator-keep-editing-on-text-submit branch February 24, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants