You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also fixes selected value not changing when last item is deleted.
Note: undoing the deletion of the last item will not update selected. As far as I could tell, undoing adds back the item that was deleted.
This lead me to conclude that there is no way of undoing the selected value without being able to determine the add was part of an undo.
This only works if you delete the last element, but you can still delete more elements at once and cause invalid button state.
Thanks for the review!
I made a new commit addressing this hopefully. Whenever the current selected value is more than the new size, it will default to selecting the last item in the list (-1 if there are no items). I only tested it with clearing the entire list; I'm not sure if there is some other way of removing items from the list I don't know about.
Thanks! Congratulations on your first merged contribution! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: undoing the deletion of the last item will not update selected. As far as I could tell, undoing adds back the item that was deleted.
This lead me to conclude that there is no way of undoing the selected value without being able to determine the add was part of an undo.