Do not grab focus on filename LineEdit in EditorFileDialog when outside the tree

[Rubonnek]

When a POT is generated for the first time, last_pot_path is added to the project metadata and this value gets used the next time the Editor runs to configure the POT generator dialog.

The problem is that currently the code configures the dialog too early and an error shows up the next time the Editor runs:

ERROR: Condition "!is_inside_tree()" is true.
   at: grab_focus (scene/gui/control.cpp:2210)

This PR fixes this issue.

To reproduce the bug, simply run the following project in the CLI:

POTGeneratorDialogBug.zip

[timothyqiu]

I checked the relevant code and I think the error is caused by the EditorFileDialog instead of the POT generator. Calling set_current_file() when the dialog is not in tree should not try to focus the filename LineEdit.

[Rubonnek]

when the dialog is not in tree should not try to focus the filename LineEdit

Patched EditorFileDialog to match this behavior which is also the current behavior in FileDialog as implemented back in #56457.

The LineEdit focus is still grabbed afterwards when the dialog itself is popped up.

[timothyqiu]

LGTM

[KoBeWi]

You can instead move this call into the condition below:

godot/editor/gui/editor_file_dialog.cpp

Lines 1422 to 1424 in 34f005d

	_focus_file_text();
	if (is_visible()) {

_focus_file_text() is called on dialog popup, so it's irrelevant when the dialog is hidden.

[Rubonnek]

You can instead move this call into the condition below

Done.

[Repiteo]

Thanks!