Skip to content

Make sure clicking AnimationTree node open the state machine editor not the track editor.#106334

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
harrisyu:tweeak-fix-feature
May 19, 2025
Merged

Make sure clicking AnimationTree node open the state machine editor not the track editor.#106334
Repiteo merged 1 commit into
godotengine:masterfrom
harrisyu:tweeak-fix-feature

Conversation

@harrisyu
Copy link
Copy Markdown
Contributor

@harrisyu harrisyu commented May 13, 2025

Fix #93455 .

@TokageItLab
Copy link
Copy Markdown
Member

TokageItLab commented May 14, 2025

I remember there was a similar PR #93632 and issue #93455 and godotengine/godot-proposals#11009, but it is basically a matter of display priorities. We will need to make sure this is the right direction. cc @AThousandShips @KoBeWi

@TokageItLab TokageItLab requested review from a team May 14, 2025 01:55
@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented May 14, 2025

Did some testing and it seems to work correctly. The editor will open the correct bottom tab, the Animation tab is correctly updated when AnimationTree is selected and you can still switch to it. It's the best solution so far.

What would not work is when both Animation and AnimationTree are supposed to show, with Animation having a priority. I don't think such scenario is possible? 🤔

@TokageItLab
Copy link
Copy Markdown
Member

What would not work is when both Animation and AnimationTree are supposed to show, with Animation having a priority. I don't think such scenario is possible? 🤔

I think it is fine that clicking on the AnimationTree opens the AnimationTree tab.

@harrisyu harrisyu requested review from a team as code owners May 16, 2025 13:27
@KoBeWi KoBeWi removed request for a team May 16, 2025 20:32
@Repiteo Repiteo merged commit 7258540 into godotengine:master May 19, 2025
40 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented May 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting AnimationTree Node didn't jump to the bottom panel of AnimationTree

5 participants