Improve ScriptLanguage get keyword API#106374
Merged
Merged
Conversation
YYF233333
changed the title
ScriptLanguage get keyword APIScriptLanguage get keyword API
Ivorforce
approved these changes
May 14, 2025
Member
There was a problem hiding this comment.
Looks good! Considering GDExtension already uses Vector, this should bring everything in line (and make calls much faster meanwhile).
Just in case I'm missing anything about the APIs, it would be good to get a GDExtension or script languages review too.
Edit: And I think this one needs a squash too.
Contributor
Author
Seperate these changes to make review easier. Please tell me if this is ready for merge and I'll squash commits. |
Contributor
Author
|
Seems no more reviews. I think it's time to suqash commits. |
YYF233333
force-pushed
the
opt_script_get_keyword
branch
from
9739f26 to
67eaaf3
Compare
akien-mga
approved these changes
May 17, 2025
akien-mga
reviewed
May 17, 2025
Member
There was a problem hiding this comment.
The p_language check is now redundant since you check it above.
YYF233333
force-pushed
the
opt_script_get_keyword
branch
from
67eaaf3 to
1384e82
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly focuses on codestyle improvements. There should be some performance gains (by eliminating unneeded copies), but I don't think these functions will become a bottleneck.