Optimize and simplify sarray#106445
Merged
Merged
Conversation
Ivorforce
approved these changes
May 15, 2025
Member
There was a problem hiding this comment.
We still have the initializer_list conundrum (godotengine/godot-proposals#12247), but it's probably still faster to use initializer_list here than repeated push_back without chance to reserve.
In either case, sarray is normally used in non bottleneck code, so simplification is welcome.
PS. I've had a look at this code some time as well, and there's a bunch of other functions with the same pattern across the code base. Perhaps you're interested to address these as well.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it a one liner as we have
std::initializer_listsupport now, no need for recursion.