Image: Fix detecting color channels#106486
Merged
Merged
Conversation
akien-mga
approved these changes
May 16, 2025
Member
|
I think this is a good change, but I can't review it in depth now. Consider this approval. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #106437
The code for detecting the resulting channel configuration operated under the assumption that each color channel that was part of said configuration had to be present in an image.
This is the most common scenario, but the channel remapping feature made the issue more likely to come across.
Now, the configurations are selected based on the presence of the outermost channel. (i.e. A -> RGBA, B -> RGB, G -> RG, R-> R).