Fix ios aot dotnet crash#106511
Closed
TCROC wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
NOTE: I don't like this PR. Although I do think we should maybe document or list out warnings surrounding having "optimize" enabled to true on ios until we solve the other issue. But for now I'm going to close this PR and likely revert it in my own fork in favor of adding this to my root csproj: <Optimize Condition="'$(GodotTargetPlatform)' == 'ios'">false</Optimize> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ios portion of:
#96072
I noticed that this user also reported they are having crashes on their windows machine. I'll see if I can reproduce it on ours as well. Currently I've only fixed it for ios. Granted I'm not super happy with this fix as the solution is to just disable optimizations entirely. Maybe a more fine grained approach of disabling optimizations per godot interface method is better.