Fix LineEdit with secret checked reveals the secret when a selection is dragged#106565
Merged
Repiteo merged 1 commit intoMay 19, 2025
Merged
Conversation
Member
|
A property disabling another property? Not to mention that you can still enable dragging afterwards (or it can be enabled accidentally when loading a scene). Instead you should disable dragging regardless of |
Contributor
Author
Still learning the ways of Godot :)
Makes sense! Will update the PR. |
pippenpaddleopsicopolis
force-pushed
the
line-edit-secret-drag
branch
from
4141773 to
52eada7
Compare
pippenpaddleopsicopolis
force-pushed
the
line-edit-secret-drag
branch
from
52eada7 to
296bee6
Compare
KoBeWi
approved these changes
May 19, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106564
Checked how an HTML5
<input type="password">behaves and the drag and drop are disabled.Before
Screen.Recording.2025-05-18.at.18.22.02.mov
After
Screen.Recording.2025-05-18.at.18.30.18.mov