Fix MenuBar min size not updating after child rename#106815
Merged
Merged
Conversation
bruvzg
reviewed
May 26, 2025
Member
bruvzg
left a comment
There was a problem hiding this comment.
Both queue_redraw and update_minimum_size probably should be called after the loop, and can be wrapped in if (!is_global) { ... } since neither is relevant for macOS global menu.
bef0c91 to
b2d4735
Compare
bruvzg
approved these changes
May 26, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce the issue:
MenuBar.PopupMenuchild for it.PopupMenunode so the button text is shorter on the menu bar.