Core: Remove implicit conversions from Callable and Signal to String, to avoid accidental conversions
#107379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String, to avoid accidental conversions #107295Same idea as above - we want to avoid accidentally converting to
String, because it's expensive.This also happens to fix another exact same type of bug as #107289, where
Callablewas accidentally converted toStringbefore hashing, making usingCallableasHashMapkeys very slow. There is already a dedicatedhash()function forCallable- it just wasn't used.After this PR, there are just 4 implicit
Stringconversions left:Variant- probably can't fix this now,Varianthas all the implicit conversions.StringName- probably fine for now since it's usually fast (at least on repeated access).NodePath- there's a lot of accessors, so it needs its own PR.IPAddress- there's a lot of accessors, so it needs its own PR.