[Web & Android] Hide more export options dynamically #107464
Open
+66
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Jun 12, 2025
dsnopek
requested changes
Jun 13, 2025
There was a problem hiding this comment.
@akien-mga mentioned this on the other PR as well, but why do we need the the new export_option_set() rather than using _get_export_option_visibility()?
UPDATE: Ah, I see that you've replied there now! I'll dig into what you wrote
|
|
adamscott
force-pushed
the
hide-options-exports
branch
from
6fa3a44 to
71de926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to/depends on #107429.
This PR hides dynamically PWA options for Web and Gradle build options for Android exports.
Enregistrement.d.ecran.le.2025-06-12.a.16.39.40.mov
Enregistrement.d.ecran.le.2025-06-12.a.16.36.51.mov