Specify Apache license version for Grisu2#108400
Merged
Merged
Conversation
AThousandShips
added
enhancement
topic:thirdparty
cherrypick:4.3
bruvzg
approved these changes
Jul 9, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
It's using version 2.0, and this line should use the same name as the License: section in the end of the file listing full license texts, which is marked as Apache-2.0.
Calinou
approved these changes
Jul 9, 2025
Contributor
|
Thanks! |
Member
|
This code was added for Godot 4.5 (#98750), and it doesn't exist in Godot 4.3 and 4.4, so the cherry-pick is not needed. |
aaronfranke
removed
cherrypick:4.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grisu2 algorithm implementation used was originally released under the MIT license, then the simdjson authors slightly modified it and their changes are released under Apache 2.0 license.