Optimize and clean up HashSet::clear#108698
Merged
Merged
Conversation
Ivorforce
approved these changes
Jul 17, 2025
Member
There was a problem hiding this comment.
This is a simple enough improvement, and should slightly help performance.
The for loop will likely be optimized away anyway, but we have it wrapped in if constexpr in other places anyway just to be sure about it.
To release managers: Please note that we have #107045 open which also touches this code. I would prefer for #107045 to be merged first.
AThousandShips
changed the title
Contributor
|
Could you rebase the PR and squash your commits? See our pull request guidelines for more information |
Brogolem35
force-pushed
the
hashset_clear_optimize
branch
from
56385ad to
7685cb6
Compare
Contributor
Author
I resolved conflict and squashed the history. |
Ivorforce
approved these changes
Sep 21, 2025
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
akien-mga
changed the title
HashSet::clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a minor cleanup on
HashSet::clear().Thing done:
Use
memsetinstead of a for loop to clear the hashes array.Check if destructor should be called on keys on compile time to avoid unnecessary iteration.