Do not poll for system theme changes#108705
Merged
Merged
Conversation
KoBeWi
approved these changes
Jul 17, 2025
Member
KoBeWi
left a comment
KoBeWi
left a comment
There was a problem hiding this comment.
Works correctly, tested on Windows.
bruvzg
approved these changes
Jul 18, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Should be fine, timer was implemented before DS callback.
Contributor
Author
|
Thanks for those pointers. I noticed that #87384 said “all platforms, except web” so I checked and |
The DisplayServer interface has change notification for theme changes. As far as I can tell, all display servers with a concept of system theme also implement the DisplayServer::set_system_theme_change_callback(const Callable &p_callable) method. So there should be no need to poll every second for the system theme.
wjt
force-pushed
the
dont-poll-system-theme
branch
from
e139099 to
f6ee1e1
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DisplayServer interface has change notification for theme changes. As far as I can tell, all display servers with a concept of system theme also implement the DisplayServer::set_system_theme_change_callback(const Callable &p_callable) method. So there should be no need to poll every second for the system theme.
This change is only lightly tested on a single platform (GNOME 43). I spotted the polling while working on #108704. The cost of polling is not huge, but in the XDG implementation (and possibly others) it's a blocking IPC call – probably better avoided.