Skip to content

Assert that dictionary.h does not include String, and that neither of the fundamental containers include Object #111342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

Assert that dictionary.h does not include String, and that neither of the fundamental containers include Object #111342

merged 1 commit into from
Oct 9, 2025

Conversation

@Ivorforce
Copy link
Member

@Ivorforce Ivorforce commented Oct 6, 2025 •
edited
Loading

Now that hashfuncs includes have been simplified, we can add some more assertions to prevent regressions.

@Ivorforce
Assert that dictionary.h does not include String, and that neithe…
839e035 
…r of the fundamental containers include `Object`.
@Ivorforce Ivorforce added this to the 4.x milestone Oct 6, 2025
@Ivorforce Ivorforce requested a review from a team as a code owner October 6, 2025 21:05
@akien-mga akien-mga modified the milestones: 4.x, 4.6 Oct 9, 2025
@Repiteo Repiteo merged commit c41e470 into godotengine:master Oct 9, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 9, 2025

Thanks!

@Ivorforce Ivorforce deleted the dict-assert-no-string branch October 9, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

enhancement topic:core

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

3 participants

@Ivorforce @Repiteo @akien-mga