Skip to content

GLTF: Write integer min/max for integer accessors #111612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Repiteo merged 1 commit into from
Nov 14, 2025
Merged

GLTF: Write integer min/max for integer accessors #111612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions modules/gltf/structures/gltf_accessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,8 +1173,28 @@ Dictionary GLTFAccessor::to_dictionary() const {
}
dict["componentType"] = component_type;
dict["count"] = count;
dict["max"] = max;
dict["min"] = min;
switch (component_type) {
case COMPONENT_TYPE_NONE: {
ERR_PRINT("glTF export: Invalid component type 'NONE' for glTF accessor.");
} break;
case COMPONENT_TYPE_SIGNED_BYTE:
case COMPONENT_TYPE_UNSIGNED_BYTE:
case COMPONENT_TYPE_SIGNED_SHORT:
case COMPONENT_TYPE_UNSIGNED_SHORT:
case COMPONENT_TYPE_SIGNED_INT:
case COMPONENT_TYPE_UNSIGNED_INT:
case COMPONENT_TYPE_SIGNED_LONG:
case COMPONENT_TYPE_UNSIGNED_LONG: {
dict["max"] = PackedInt64Array(Variant(max));
dict["min"] = PackedInt64Array(Variant(min));
} break;
case COMPONENT_TYPE_SINGLE_FLOAT:
case COMPONENT_TYPE_DOUBLE_FLOAT:
case COMPONENT_TYPE_HALF_FLOAT: {
dict["max"] = max;
dict["min"] = min;
} break;
}
dict["normalized"] = normalized;
dict["type"] = _get_accessor_type_name();

Expand Down