Fix BaseMaterial3D UV Offset/Scale and Emission on UV2 ignored when baking VoxelGI #111974
+66
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:rendering
topic:3d
cherrypick:4.5
…aking VoxelGI UV1/UV2 Triplanar properties are still ignored, but implementing them is much more involved as triplanar sampling would have to be reimplemented from scratch in the voxelizer.
Calinou
force-pushed
the
voxelgi-use-uv1-offset-scale
branch
from
c1c6ca8 to
0da9c4b
Compare
Calinou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UV1/UV2 Triplanar properties are still ignored, but implementing them is much more involved as triplanar sampling would have to be reimplemented from scratch in the voxelizer.
Note that adjusting UV2 Scale/Offset will affect baking, but it doesn't affect the real-time emission map in either Forward+ or Compatibility here. I'm not sure if this is a bug (and whether we should remove the UV2 Scale/Offset adjustment from the voxelizer).
Testing project: test_voxelgi_uv.zip
cc @betalars
Preview
The source texture has 3 colored dots at 1:1 scale, but the plane uses an UV scale and offset to repeat it.
Before
After