GLTF: Add export_get_property_list to GLTFDocumentExtension#113247
Merged
Conversation
lyuma
reviewed
Dec 1, 2025
lyuma
left a comment
lyuma
left a comment
Contributor
There was a problem hiding this comment.
I think it looks fine, but probably needs consensus at the next meeting just to make sure we're all happy with moving forward.
Basically given that the old system was already shipped in Godot, I want to weigh changing this against keeping the usual property list system that is already in place.
aaronfranke
force-pushed
the
gltf-property-list
branch
from
28600a0 to
93879d1
Compare
aaronfranke
force-pushed
the
gltf-property-list
branch
from
93879d1 to
ef163a3
Compare
aaronfranke
force-pushed
the
gltf-property-list
branch
from
ef163a3 to
2c67ee6
Compare
aaronfranke
force-pushed
the
gltf-property-list
branch
from
2c67ee6 to
99e4431
Compare
fire
approved these changes
Apr 11, 2026
github-project-automation
Bot
moved this from Ready for review
to Done
in Asset Pipeline Issue Triage
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new callback method that runs before the entire export process begins, which returns the
PropertyInfolist of the properties relevant for that class. This allows extensions to provide context-sensitive options without cluttering the menu.For example, PR #112866 uses this feature to show this dropdown menu when there are MultiMeshInstance3D nodes in the scene, but hide it when none exist in the scene:
I also fixed a bug where the extension name wasn't considering the GDScript class name when it should. I also removed the call to
capitalizesince it actually makes no difference since the inspector already callscapitalize.