Fix FBX import normals to respect smoothing groups#114758
Draft
fire wants to merge 2 commits into
Draft
Conversation
fire
force-pushed
the
fix-ufbx-smooth-normals
branch
3 times, most recently
from
130abf8 to
d395ae4
Compare
Generate normals based on FBX face_smoothing data: - Smooth faces share averaged normals across vertices - Faceted faces maintain hard edges - Preserves artist-defined smoothing behavior
fire
force-pushed
the
fix-ufbx-smooth-normals
branch
from
d395ae4 to
f0086ff
Compare
Member
Author
|
Feature request: Kosyne found it convenient to be able to choose between calculating, importing or outright discarding smoothing group data. |
Member
Author
|
Discussed with @bqqbarbhg We think that ufbx is probably doing the "correct" thing here, but many things export hard edges unexpectedly. So it's a good idea to default to what the fbx file says, or discarding smooth data or discarding hard edges or we can try recalculating (this pull request). |
AThousandShips
added
bug
topic:import
cherrypick:4.5
Co-authored-by: A Thousand Ships <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate normals based on FBX face_smoothing data:
Fixes: #114739