Fix create dialog recents

[Saulo-de-Souza]

The CreateDialog::get_selected_type() method can return an empty string for custom types.

When EditorNode::get_editor_data().get_custom_type_by_name() returns nullptr, it relies on _script_path, which is only defined for global script classes. As a result, _confirmed() terminates prematurely (selected_item.is_empty()), therefore the recent history is never shown for custom types.

Returning the visible name of the selected item (selected->get_text(0)) corrects the problem and matches how Recent/Favorite items are already handled (based on name, not path).

See the before and after photos below:

---

---

[KoBeWi]

Returning script path is deliberate. It's needed for popup_create_dialog() method. In scripting, it's not possible to instantiate a script having only its class name string. See #106071

If it's a problem for history, add a new method that returns the actual type name.

[Saulo-de-Souza]

Returning script path is deliberate. It's needed for popup_create_dialog() method. In scripting, it's not possible to instantiate a script having only its class name string. See #106071

If it's a problem for history, add a new method that returns the actual type name.

That's correct. I made a change. Could you please verify if it's correct now? Thank you for your attention!

[Repiteo]

Could you squash your commits? See our pull request guidelines for more information

[Saulo-de-Souza]

Could you squash your commits? See our pull request guidelines for more information

This branch contains a single commit on top of master. The PR can be squashed on merge.

[akien-mga]

No your branch actually contains 3 commits:

You should do an interactive rebase to drop the first 2 I assume.

[Saulo-de-Souza]

No your branch actually contains 3 commits:

You should do an interactive rebase to drop the first 2 I assume.

Done!

[Repiteo]

Your commit seems to not be linked to your GitHub account. See this article for more information

[Saulo-de-Souza]

Your commit seems to not be linked to your GitHub account. See this article for more information

Thanks for the heads up! I’ve rewritten the commits so they’re now authored with the same GitHub account that opened the PR.

[Repiteo]

Thanks! Congratulations on your first merged contribution! 🎉

[Repiteo]

Cherry-picked for 4.6.1.