Skip to content

Make Instant Preview work for first selection after being enabled#116651

Open
Meorge wants to merge 1 commit into
godotengine:masterfrom
Meorge:bugfix/ql-ip-first-selection-no-effect
Open

Make Instant Preview work for first selection after being enabled#116651
Meorge wants to merge 1 commit into
godotengine:masterfrom
Meorge:bugfix/ql-ip-first-selection-no-effect

Conversation

@Meorge
Copy link
Copy Markdown
Contributor

@Meorge Meorge commented Feb 23, 2026

Closes #116650 .

This PR shifts a little logic around for the Quick Load window so that regardless of Instant Preview's enabled status on window open, the initial selection done by the window itself is still counted, and thus the first selection by the user is always detected.

Godot.QL.IP.Fix.for.Second.Selection.Issue.mp4

@Meorge Meorge requested review from a team as code owners February 23, 2026 06:23
@AThousandShips AThousandShips added this to the 4.x milestone Feb 23, 2026
@AdriaandeJongh AdriaandeJongh removed the request for review from a team February 27, 2026 11:21
Copy link
Copy Markdown
Contributor

@AdriaandeJongh AdriaandeJongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the code, but this is the expected behavior.

@AdriaandeJongh AdriaandeJongh modified the milestones: 4.x, 4.7 Feb 27, 2026
@Meorge Meorge force-pushed the bugfix/ql-ip-first-selection-no-effect branch from 5792b13 to 04e65c7 Compare March 7, 2026 23:30
@Meorge Meorge force-pushed the bugfix/ql-ip-first-selection-no-effect branch 2 times, most recently from 8679223 to a743d6b Compare April 13, 2026 16:58
@Meorge Meorge force-pushed the bugfix/ql-ip-first-selection-no-effect branch from a743d6b to f36c9aa Compare May 12, 2026 03:59
@Meorge Meorge force-pushed the bugfix/ql-ip-first-selection-no-effect branch from f36c9aa to 430b4b8 Compare May 30, 2026 16:31
Comment thread editor/gui/editor_quick_open_dialog.cpp Outdated
@Meorge Meorge force-pushed the bugfix/ql-ip-first-selection-no-effect branch from 1794ab5 to 22c8e88 Compare June 1, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instant Preview does not take effect for first selected item after being enabled

5 participants