Fix EditorPlugin::remove_control_from_docks freeing passed control#117337
Merged
Repiteo merged 1 commit intoJun 1, 2026
Merged
Conversation
0c11fe2 to
b7f9305
Compare
KoBeWi
reviewed
Mar 11, 2026
b7f9305 to
e4a5d61
Compare
e4a5d61 to
cdc278d
Compare
KoBeWi
approved these changes
Jun 1, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117331.
Fixes a regression from #106503 which made
remove_control_from_docks(docked_control)result in freeing the passeddocked_control.After #106503 when a Control is added to a dock with
add_control_from_dockit is wrapped into an EditorDock node by adding it as its child. Onremove_control_from_dockssuch EditorDock is freed, but the wrapped control was never being removed from it, hence it was freed together with its parent. This is a regresion / compatibilty breakage, asremove_control_from_docksis documented to not free the passed control and tells clearly it's the user responsibility.godot/doc/classes/EditorPlugin.xml
Lines 681 to 686 in 9095a76